Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some SQL debug logs to unclutter the output. #5634

Merged
merged 1 commit into from
May 4, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Apr 28, 2023

Thousands of useless lines make investigating logs really hard. Time to get rid of those. We can always add them if needed for specific case.

@allexzander
Copy link
Contributor Author

/backport to stable-3.8

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #5634 (77f59c2) into master (cc69701) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5634      +/-   ##
==========================================
- Coverage   59.26%   59.24%   -0.03%     
==========================================
  Files         143      143              
  Lines       18455    18445      -10     
==========================================
- Hits        10938    10928      -10     
  Misses       7517     7517              
Impacted Files Coverage Δ
src/common/ownsql.cpp 66.93% <ø> (+0.40%) ⬆️
src/common/ownsql.h 81.25% <ø> (-18.75%) ⬇️

... and 2 files with indirect coverage changes

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/sql-logs-unclutter branch from eac43e7 to 77f59c2 Compare May 4, 2023 12:42
@allexzander allexzander merged commit 19d796e into master May 4, 2023
@allexzander allexzander deleted the feature/sql-logs-unclutter branch May 4, 2023 14:06
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5634-77f59c26d36423b92037896c119d9c7204178c88-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants